[Bug 191304] Review Request: crossfire-client - Client programs for the crossfire game

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: crossfire-client - Client programs for the crossfire game


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=191304


chris.stone at gmail.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
OtherBugsDependingO|163778                      |163779
              nThis|                            |




------- Additional Comments From chris.stone at gmail.com  2006-05-15 22:43 EST -------
* rpmlint output clean
* Package named according to Package Naming Guidelines
* Spec file matches base package %{name}
* Package meets packaging guidelines
* License is open source compatible
* License matches actual license
* License file contained in %doc
* Spec file in American English
* Spec file is legible
* Source file matches upstream
62a9ac007700d1d811fa097fe6790f7a  crossfire-client-1.9.0.tar.gz
62a9ac007700d1d811fa097fe6790f7a  crossfire-client-1.9.0.tar.gz
* Package successfully builds for FC5 x86_64
* All build dependencies listed in Build Requires
* Package does not contain locales
* Package does not contain any shared libraries
* Package is not relocatable
* Package owns the directories it creates
* No duplicate files in %files
* %files contains acceptable %defattr settings
* Package contains acceptable %clean section
* Macro use is consistant
* Package contains permissible code
* No large amounts of documentation for a -doc package
* Files in %doc do not affect run time of application
* No header files or static libraries. or .pc files present
* No .so files present
* No devel package built
* No .la files present
* Package include .desktop file
  - Should probably use %{name}.desktop
* Package does not own files or directories owned by other packages

*** APPROVED ***

Non-Blocking SHOULDS:
- Contact upstream about sound problem (I'm assuming you already have done this)
- Contact upstream about -images package (Noted that you have done this)
- Build -sounds package when sound is working (Probably already on your TODO list)

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.