[Bug 191603] Review Request: rsnapshot -- rsync-based filesystem snapshots

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: rsnapshot -- rsync-based filesystem snapshots


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=191603





------- Additional Comments From tibbs at math.uh.edu  2006-05-16 14:29 EST -------
Your Source: URL is fine if you just change the version to 1.2.3;
http://rsnapshot.org/downloads/ has all of the released versions.  I checked CVS
and it looks like they're going to release 1.2.4 soon.

Looking at the rpmforge .spec, there's not too much differece once you ignore
whitespace and your section separators.

Rpmforge spec:
Uses macros on the %configure line instead of hardcoding the paths.
Has lots of BuildReqires; I'm not sure if they're necessary.
Neatly calls logger in %post to make sure that errors get logged somewhere.
Patches the default config.
Packages the utils directory as %doc (which should annoy rpmlint; extras doesn't
generally like executable documentation).

Your spec:
Does that hack to avoid configure freaking out on an existing config file. Nice.
Does Require: openssh instead of openssh-clients; I'm not sure which is correct.

I'll attach the rpmforge spec.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.