[Bug 191303] Review Request: crossfire - 2D multiplayer rpg game server

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: crossfire - 2D multiplayer rpg game server


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=191303





------- Additional Comments From chris.stone at gmail.com  2006-05-16 20:32 EST -------
* rpmlint output
E: crossfire non-standard-uid /var/games/crossfire/temp.maps crossfire
E: crossfire zero-length /var/games/crossfire/temp.maps
E: crossfire non-standard-uid /var/games/crossfire/clockdata crossfire
E: crossfire zero-length /var/games/crossfire/clockdata
E: crossfire non-standard-uid /var/games/crossfire/template-maps crossfire
E: crossfire non-standard-uid /var/games/crossfire/banish_file crossfire
E: crossfire zero-length /var/games/crossfire/banish_file
E: crossfire non-standard-uid /var/games/crossfire crossfire
E: crossfire non-standard-uid /var/games/crossfire/players crossfire
E: crossfire non-standard-uid /var/games/crossfire/maps crossfire
E: crossfire non-standard-uid /var/games/crossfire/highscore crossfire
E: crossfire zero-length /var/games/crossfire/highscore
E: crossfire non-standard-uid /var/games/crossfire/unique-items crossfire
E: crossfire non-standard-uid /var/games/crossfire/bookarch crossfire
E: crossfire zero-length /var/games/crossfire/bookarch
E: crossfire non-standard-uid /var/games/crossfire/datafiles crossfire
E: crossfire non-standard-uid /var/log/crossfire crossfire
W: crossfire incoherent-subsys /etc/rc.d/init.d/crossfire $prog
W: crossfire-client-images no-documentation
W: crossfire-plugins no-documentation

non-standard-uid and zero-length files okay
incoherent-subsys looks like a false positive
no-documentation warnings okay

* Package meets Package Naming Guidelines
* Spec file matches base package %{name}
* Package meets Packaging Guidelines
* Package licensed with open source compatible license
* License field matches actual license
* License text file included in %doc
* Spec file written in American English
* Spec file legible
* Sources match upstream
43240af83a4414d2dcc19fff3af31a63  crossfire-1.9.0.tar.gz
43240af83a4414d2dcc19fff3af31a63  crossfire-1.9.0.tar.gz
7685cc806a02a3f14336095de6066128  crossfire-1.9.0.arch.tar.gz
7685cc806a02a3f14336095de6066128  crossfire-1.9.0.arch.tar.gz
* Package successfully builds on FC5 x86_64
* All build dependencies listed in BuildRequires
* Package does not contain locales
* Package does not contain shared library files
* Package is not relocatable

O Package does not own all directories it creates
  - Package does not own /etc/crossfire directory

* Package does not contain any duplicates in %files section
* Files have sane attributes (crossfire user created with fedora-usermgnt and sh
ared scoreboard files belong to crossfire user as per games SIG guidelines)
* Package contains proper %clean section
* Macro usage consistant
* Package contains permissible content

O Crossfire documentation is 4 megs (might want to consider making a seperate -d
oc package)

* Files in %doc do not affect runtime
* Package does not contain headers, library files or .pc files
* Package does not contain any .so files
* -devel and -plugins package requires base package

O -client-images package should require crossfire-client, if that makes sense?

* Package does not contain any .la files
* Package does not need a .desktop file
* Package does not own files or directories owned by other packages


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.