[Bug 191998] Review Request: scrip -- spherical coordinate interpolation and remapping package

bugzilla at redhat.com bugzilla at redhat.com
Wed May 17 16:39:34 UTC 2006


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: scrip -- spherical coordinate interpolation and remapping package


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=191998


pertusus at free.fr changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
OtherBugsDependingO|163776                      |163779
              nThis|                            |




------- Additional Comments From pertusus at free.fr  2006-05-17 12:39 EST -------
* rpmlint is silent
* naming is good
* follow packaging guidelines
* licence acceptable and included
* spec legible
* source match upstream
* everything else is fine
* builds in mock

APPROVED

comments:
* the timestamp of the sources is wrong, I find it better to have
the right timestamp. In general I use spectool to achive that (or
maybe wget -N). 
* the executables in grids/ may be compiled and distributed maybe with
scrip_ prefixed, and in that case the README file may also be added, 
renamed for example README.utils.
* the bugs file could be in %docs

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.




More information about the Fedora-package-review mailing list