[Bug 176374] Review Request: nagios-plugins

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: nagios-plugins


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=176374





------- Additional Comments From jpo at di.uminho.pt  2006-05-17 18:59 EST -------
Missing requirements in perl plugins
------------------------------------

The perl module - utils.pm - as the following lines modified by the
configure script (utils.sh also has similar lines).
--------
## updated by autoconf
$PATH_TO_RPCINFO = "/usr/sbin/rpcinfo" ;
$PATH_TO_NTPDATE = "/usr/sbin/ntpdate" ;
$PATH_TO_NTPDC   = "/usr/sbin/ntpdc" ;
$PATH_TO_NTPQ    = "/usr/sbin/ntpq" ;
$PATH_TO_LMSTAT  = "" ;
$PATH_TO_SMBCLIENT = "/usr/bin/smbclient" ;
$PATH_TO_MAILQ   = "/usr/bin/mailq";
$PATH_TO_QMAIL_QSTAT = "";

and these variables are used by some of the perl plugins. For example,
the check_ntp should require the ntp package 

    Code used by in the check_ntp plugin
    ---------
    my $ntpdate = $utils::PATH_TO_NTPDATE;
    my $ntpq    = $utils::PATH_TO_NTPQ;
    ...
    open (NTPDATE, $ntpdate . " -q $host 2>&1 |")
    ...
    open(NTPQ, $ntpq . " -np $host 2>&1 |")


Plugins with missing requirements:

* nagios-plugins-mailq
  should require the /usr/bin/mailq file (or sendmail (?))

* nagios-plugins-ntp
  should require the ntp package (or the above ntp utilities)

* nagios-plugins-disk_smb
  should require the samba-client package or the /usr/bin/smbclient binary


Directory ownership
------------------------------------
the nagios-plugins base rpm should also own the
  /usr/lib/nagios/plugins/ directory


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.