[Bug 191239] Review Request: qjackctl - Qt based JACK control application

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: qjackctl - Qt based JACK control application


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=191239





------- Additional Comments From nando at ccrma.stanford.edu  2006-05-18 17:47 EST -------
(In reply to comment #11)
> NEEDSWORK:
> 
> Source: seems to need to be http://dl.sf.net/sourceforge/qjackctl/[...] 
> otherwise I get a 404 as is.

Fixed.

> The Requires: jack-audio-connection-kit >= 0.80.0  is unnecessary as no such old
> version is going to be in Extras.

Fixed (comment: Extras does not live in a vaccum, the requires line would have
addressed Planet CCRMA users that have old versions and migrate to the extras
package - I know, very unlikely, but if experience is any guide if it can happen
it will).

> The generic INSTALL instructions should not be packaged.
> 
> The desktop file should be included as Source:, not embedded in the spec, as
> shown in the Desktop Files section of the packaging guidelines.

Fixed.

Spec URL: http://ccrma.stanford.edu/planetccrma/extras/qjackctl.spec
SRPM URL: http://ccrma.stanford.edu/planetccrma/extras/qjackctl-0.2.20-4.0.src.rpm


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.