[Bug 191534] Review Request: pygobject2

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: pygobject2


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=191534





------- Additional Comments From jkeating at redhat.com  2006-05-19 16:16 EST -------
Bad:
- Buildroot should be %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)
- Description line should be 80chars max per line
- rpmlint isn't happy w/ the build package:
E: pygobject2 script-without-shellbang
/usr/share/doc/pygobject2-2.10.1/examples/Makefile.in
E: pygobject2 script-without-shellbang
/usr/share/doc/pygobject2-2.10.1/examples/signal.py
E: pygobject2 script-without-shellbang /usr/lib64/python2.4/site-packages/pygtk.pth
E: pygobject2 script-without-shellbang
/usr/share/doc/pygobject2-2.10.1/examples/Makefile
E: pygobject2 script-without-shellbang /usr/share/doc/pygobject2-2.10.1/AUTHORS
E: pygobject2 script-without-shellbang /usr/lib64/python2.4/site-packages/pygtk.py
E: pygobject2 script-without-shellbang /usr/share/doc/pygobject2-2.10.1/README
E: pygobject2 script-without-shellbang /usr/share/doc/pygobject2-2.10.1/NEWS
E: pygobject2 script-without-shellbang
/usr/share/doc/pygobject2-2.10.1/examples/properties.py
E: pygobject2 script-without-shellbang /usr/share/doc/pygobject2-2.10.1/ChangeLog
E: pygobject2 script-without-shellbang
/usr/share/doc/pygobject2-2.10.1/examples/Makefile.am

rpmlint -I script-without-shellbang
script-without-shellbang :
This executable text file does not contain a shebang, thus it cannot be
properly executed.  Often this is a sign of spurious executable bits for a
non-script file, but can also be a case of a missing shebang.  To fix this
error, find out which case of the above it is, and either remove the
executable bits or add the shebang.

Perhaps the defattr is a bit overbearing?

Question:
- The dep in the -devel package could lead to -devel being out of sync w/ a
release of the main package.  Is this an issue?

Suggestion:
- No period in summary lines
- Add a URL tag

NEEDSWORK

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.