[Bug 192413] libdhcp : IPv6 and IPv4 DHCP client and network configuration library API

bugzilla at redhat.com bugzilla at redhat.com
Sat May 20 01:49:39 UTC 2006


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: libdhcp : IPv6 and IPv4 DHCP client and network configuration library API


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=192413





------- Additional Comments From jvdias at redhat.com  2006-05-19 21:49 EST -------
Firstly, the isc-dhcp issue - now dhcp-3.0.8's libdhcp4client-devel provides
<isc_dhcp/*>, not <isc-dhcp/*>, which is provided by dhcp-devel. 

Yes, libdhcp requires the dhcp-devel headers in <isc-dhcp/*> to build -
dhcp-devel is now in the build requires.

There are only two .c files in libdhcp that require the ISC DHCP headers,
dhcp4_lease.c and dhcp4_nic.c, whose purpose it could be said is to avoid any
programs which use them ever having to require the DHCP headers. 

Similarly for dhcpv6, ONLY libdhcp's dhcp6_lease.c and dhcp6_lease.nic need
to include the dhcp6 headers. 

This is shown clearly in a log of the build without the extra RPM stuff:

$ CFLAGS='-g3 -gdwarf-2' make
cc -g3 -gdwarf-2 -fPIC -I. -Wall -Werror   -c -o libdhcp.o libdhcp.c
cc -g3 -gdwarf-2 -fPIC -I. -Wall -Werror -I/usr/include/dhcp4client  
-I/usr/include/dhcp4client/isc_dhcp     -c -o dhcp4_lease.o dhcp4_lease.c
cc -g3 -gdwarf-2 -fPIC -I. -Wall -Werror -I/usr/include/dhcp4client  
-I/usr/include/dhcp4client/isc_dhcp     -c -o dhcp4_nic.o dhcp4_nic.c
cc -g3 -gdwarf-2 -fPIC -I. -Wall -Werror -I/usr/include/dhcp6client  
-I/usr/include/dhcp6client/dhcpv6   -c -o dhcp6_lease.o dhcp6_lease.c
cc -g3 -gdwarf-2 -fPIC -I. -Wall -Werror   -c -o dhcp6_nic.o dhcp6_nic.c
cc -g3 -gdwarf-2 -fPIC -I. -Wall -Werror   -c -o nic.o nic.c
cc -g3 -gdwarf-2 -fPIC -I. -Wall -Werror   -c -o dhcp_nic.o dhcp_nic.c
cc -shared -o libdhcp.so.1 -Wl,-soname,libdhcp.so.1 libdhcp.o dhcp4_lease.o
dhcp4_nic.o dhcp6_lease.o dhcp6_nic.o nic.o dhcp_nic.o -lnl   -ldhcp6client  
-ldhcp4client
/bin/ln -sf libdhcp.so.1 libdhcp.so
ar crus libdhcp.a libdhcp.o dhcp4_lease.o dhcp4_nic.o dhcp6_lease.o dhcp6_nic.o
nic.o dhcp_nic.o

About the "explicit-lib-dependency" - yes, libdhcp does require the 
libdhcp4client and libdhcp6client libraries - it cannot be used at all
without them, so I thought they should be  in its list of 'Requires:' -
rpm does not complain at all about them when I make the RPM - but I've
taken them out as you suggested.

About the devel package dep - in the current .spec file, it says:

%package devel
...
Requires:     %{name}-%{version}-%{release}

Please ensure you're looking at the latest version of the .spec file , which
is now in elvis & devel CVS .

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.




More information about the Fedora-package-review mailing list