[Bug 182064] Review Request: facter
bugzilla at redhat.com
bugzilla at redhat.com
Sat May 20 04:29:48 UTC 2006
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: Review Request: facter
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=182064
jpmahowald at gmail.com changed:
What |Removed |Added
----------------------------------------------------------------------------
OtherBugsDependingO|163778 |163779
nThis| |
------- Additional Comments From jpmahowald at gmail.com 2006-05-20 00:29 EST -------
Building for FC5 works, on FC5.
So the review:
- rpmlint checks return:
E: facter no-binary
E: facter only-non-binary-in-usr-lib
because of the mentioned bug 184199
- package meets naming guidelines
- package meets packaging guidelines
- license (GPL) OK, text in %doc, matches source
- spec file legible, in am. english
- source matches upstream
- package compiles on FC5 (x86_64)
- no missing BR
- no unnecessary BR
- no locales
- not relocatable
- owns all directories that it creates
- no duplicate files
- permissions ok
- %clean ok
- macro use consistent
- code, not content
- no need for -docs
- nothing in %doc affects runtime
- no need for .desktop file
APPROVED
--
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.
More information about the Fedora-package-review
mailing list