[Bug 173459] Review Request: initng

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: initng


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=173459


daner964 at student.liu.se changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #129586|0                           |1
        is obsolete|                            |




------- Additional Comments From daner964 at student.liu.se  2006-05-20 07:21 EST -------
Created an attachment (id=129723)
 --> (https://bugzilla.redhat.com/bugzilla/attachment.cgi?id=129723&action=view)
initng 0.6.7-2 spec file

(In reply to comment #290)
> 1. core package contains development files (*.so); write

Did I get you right now?

>    | Requires(post): procps
>    | ...
>    | init=$(ps --no-headers -o '%%c' 1)
>    | test x"$init" != xinitng || /sbin/ngc --quiet -c || :

Thanks! That's a lot nicer!

>    in -devel. Alternatively (I would prefer that), you should create a
>    '-lib' subpackage with only the libraries and require this subpackage
>    by -devel.

Something like this?

> 2. the
> 
>    | if [ -x /usr/sbin/semanage ]; then
>    |	    /usr/sbin/semanage fcontext -a -t init_exec_t /sbin/initng
2>/dev/null || :
>    | fi
> 
>    can be expressed shorter as
> 
>    | /usr/sbin/semanage fcontext -a -t init_exec_t /sbin/initng 2>/dev/null
|| :

Ok. The check was introduced since you pointed out that semanage doesn't exist
in FC4...

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.