[Bug 173459] Review Request: initng

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: initng


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=173459





------- Additional Comments From enrico.scholz at informatik.tu-chemnitz.de  2006-05-20 11:10 EST -------
> > 1. core package contains development files (*.so); write

> Did I get you right now?


sorry, not completely ;)

* you should add 
  | %post   lib -p /sbin/ldconfig
  | %postun lib -p /sbin/ldconfig

  and remove the /sbin/ldconfig from main's %scriptlets

* I am not sure about the plugins (/%{_lib}/initng); I would see them
  as part of the main-package and would not ship them in -lib.

  Beside the devel-ifiles chicken-egg problem, the purpose of -lib is
  to avoid heavy dependencies e.g. for GUIs which are using the initng
  ifiles-parser.


> >    | if [ -x /usr/sbin/semanage ]; then
> >    |	    /usr/sbin/semanage fcontext -a -t init_exec_t /sbin/initng 2>/dev/null || :
> >    | fi
> > 
> >    can be expressed shorter as
> > 
> >    | /usr/sbin/semanage fcontext -a -t init_exec_t /sbin/initng 2>/dev/null || :
> 
> Ok. The check was introduced since you pointed out that semanage doesn't exist
> in FC4...

My comment #239 was about a

| /usr/sbin/semanage fcontext -a -t init_exec_t /sbin/initng

statement *without* the trailing '|| :'

Current spec is ok regarding this issue.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.