[Bug 192144] Review Request: musicbox

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: musicbox


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=192144


bdpepple at ameritech.net changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
OtherBugsDependingO|163778                      |163779
              nThis|                            |




------- Additional Comments From bdpepple at ameritech.net  2006-05-20 13:32 EST -------
MD5Sums:
03f9eb2c446debd1e187d472c05dcad8  musicbox-0.2.3.tar.gz

Good:
* Source URL is canonical
* Upstream source tarball verified
* Package name conforms to the Fedora Naming Guide
* Group Tag is from the official list
* Buildroot has all required elements
* All paths begin with macros
* Desktop entry is fine
* All directories are owned by this or other packages
* All necessary BuildRequires listed.
* All desired features are enabled
* rpmlint produces no errors.
* Builds fine in mock.

Minor:
* Unnecessary BuildRequirement: gtk2-devel (provided by libglade2-devel)
* Don't package INSTALL doc, since it's the generic GNU file.

You can fix the 2 minor issues when you import it into FE CVS.

+1 APPROVE

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.