[Bug 190040] Review Request: hydrogen - Advanced drum machine

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: hydrogen - Advanced drum machine


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=190040





------- Additional Comments From seg at haxxed.com  2006-05-23 05:25 EST -------
MUST items:

- rpmlint: Ok?

$ rpmlint hydrogen-0.9.3-4.fc5.i386.rpm
E: hydrogen shared-lib-without-dependency-information
/usr/lib/hydrogen/plugins/wasp_xshaper.so
E: hydrogen shared-lib-without-dependency-information
/usr/lib/hydrogen/plugins/wasp_noisifier.so
E: hydrogen shared-lib-without-dependency-information
/usr/lib/hydrogen/plugins/wasp_booster.so

$ ldd /usr/lib/hydrogen/plugins/*
/usr/lib/hydrogen/plugins/wasp_booster.so:
        statically linked
/usr/lib/hydrogen/plugins/wasp_noisifier.so:
        statically linked
/usr/lib/hydrogen/plugins/wasp_xshaper.so:
        statically linked

Statically linked dynamic libraries? That's a new one to me. These are
apparently LADSPA plugins. Perhaps these should go in %{_libdir}/ladspa instead.
And even go in a "hydrogen-wasp-plugins" subpackage.

- Package name: Ok
- Spec name: Ok
- Meets packaging guidelines: Ok
- License: Ok
- Spec in American English: Ok
- Spec legible: Ok
- Sources match upstream: Ok
- Builds: Ok
- BuildRequires: Ok
- Locales: Ok
- ldconfig: NEEDSWORK
- Relocation: Ok
- Directory ownership: Ok
- %files: Ok
- %clean: Ok
- Macros: Ok
- Code vs. Content: Ok
- Documentation: Ok
- devel package: Ok
- .desktop file: Ok

SHOULD:

- Includes license text: Ok
- Mock build: Yes
- Builds on all archs: Built on i386, x86_64
- Package functional: Yes! http://www.haxxed.com/music/909fun.ogg
- Scriptlets: NEEDSWORK
- Subpackages: Ok

NEEDSWORK:

Source0 should be a full URL. It should be
http://dl.sf.net/sourceforge/hydrogen/hydrogen-0.9.3.tar.gz

You have a lingering buildreq on portaudio-devel.

I would recommend disabling OSS support. (%configure --disable-oss-support)
AFAIK OSS has been deprecated for some time now.

I don't think you need all that QTDIR stuff. It seems to build just fine without
it. Mock sources profile.d properly.

I don't think you need to update the icon cache, its not installing any into
/usr/share/icons

Don't need ldconfig, its not installing systemwide libraries.

The update-desktop-database doesn't match what's in ScriptletSnippets, and
according to ScriptletSnippets, you only need it if there's a MimeType key.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.