[Bug 192867] Review Request: ctorrent - BitTorrent Client written in C

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: ctorrent - BitTorrent Client written in C


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=192867





------- Additional Comments From yaneti at declera.com  2006-05-23 15:12 EST -------
disclaimer: I hold none of the official fedora credentials, so take my comments
as random joe observations.

Your spec file fails many of the basic requirements listed in
http://fedoraproject.org/wiki/Packaging/Guidelines
See "Writing a package from scratch" section for how to produce a basic specfile
using an existing template which should help produce something not so far off
the mark.

Here are some of the more major omissions:
- no URL tag
- source tag is not a url to the canonical upstream source.
- no explicit buildroot
- the description spills over 80 characters a line and has text mostly comprised
of advocacy rather than descritopn.
- doesn't use standard macros as %configure, %makeinstall  thus resulting in an
install to /usr/local, which is a big no no for fedora. 
- no changelog
- no spaces, resulting i poor readability.

A more detailed review will possibly follow after these basic things are taken
care of.


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.