[Bug 192867] Review Request: ctorrent - BitTorrent Client written in C

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: ctorrent - BitTorrent Client written in C


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=192867





------- Additional Comments From yaneti at declera.com  2006-05-24 02:46 EST -------
- Requires: gcc  should be removed. If there is a runtime dependancy on any gcc
lib its automatically genereated. 

- %{_bindir}/ctorrent  should work. If it doesn't you either made a typo or your
build enviroment is not quite standard fedora fare. custom macros and such...?

- your changelog is not formatted properly. The first line should end with - 
E-V-R of the package. There should be an empty newline after each new changelog
section. "Changes to .spec file" is not an actual description of what changed
therefore useles to reveiwers and users. Provide a little bit more details on
what actually changed. Something like:
 - fixed URL
 - removed unneeded Reqiures, added openssl-devel to BR.

- please remove all the trailing spaces, they might confuse rpm and other spec
handling tools. The spaces in the template are there not to trail but to align
the position of the values of the tags.

rpmlint as mandated by the guidelines should have spotted most of these


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.