[Bug 188574] Review Request: rss-glx -- Really Slick Screensavers

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: rss-glx -- Really Slick Screensavers


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=188574





------- Additional Comments From nphilipp at redhat.com  2006-05-24 12:06 EST -------
(In reply to comment #8)
> Things are looking good now.  One new rpmlint warning (a line in %description is
> too long).

Fixed.

> However, I went to test this on a couple of i386 FC5 machines under KDE (so
> rss-glx and rss-glx-kde are installed); the hacks display when run directly
> (they open a small window in the background) but as KDE screensavers there are
> some issues:
> 
> They show up at the bottom of the list, not filed under "OpenGL Screen Savers".
>  Maybe they should have their own place in the hierarchy?  ("Really Slick Screen
> Savers"?)  I think you do this by using X-KDE-Category= in the desktop file. 
> It's probably also worth using X-KDE-Type=OpenGL as well.  But it looks like
> you're just using the desktop files supplied by upstream here; I'm not sure if
> it's worth it to hack them up.
> 
> The desktop files include "Actions=InWindow;Root" but then go on to define a
> Setup action as well.

Let others decide whether it was worth it, it was just one line of awk per
desktop file ;-).

> The setup page for each screensaver doesn't work at all unless you also install
> rss-glx-screensaver.  Should this be a dependency of rss-glx-kde, or is
> something else wrong?

Seems KDE (specifixally its kxs* tools) depends on the XSS files being in place
for all XSS-like hacks. I've added a dependency.

> The screensavers don't actually do anything; the "Test" button causes the
> desktop to pause (system monitor and clock stop updating), but nothing is
> actually displayed.  This happens on my home machine with binary Nvidia driver
> and a machine here at work with a Radeon R200 (stock X driver).  Any ideas?

Not ATM. I'll try it at a colleague's desktop (he uses KDE) to see whether the
above fixes change anything in that regard.

I've put the new package at (note the added ".p" in the version to indicate that
we're working with modified sources):

http://tiptoe.de/dav/rss-glx-0.8.1.p-0.5.src.rpm

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.