[Bug 192918] Review Request: kerry - Kerry Beagle is a KDE frontend for the Beagle desktop search

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: kerry - Kerry Beagle is a KDE frontend for the Beagle desktop search


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=192918





------- Additional Comments From hugo at devin.com.br  2006-05-25 04:47 EST -------
Hi Aurelien! Thanks for your input on this.

Before I update the specfile, let me comment some things.

> * replace /usr with %{_prefix}

Done.

> * removing *.la files in %_libdir is a good thing, but *.la files in 
>   %_libdir/kde3 are usually needed by KDE

I came across this problem with some other packages, but I tested this package 
and it appears that it's fully working without the %{_libdir}/kde3/*.la files. 
But to be sure, I'm including again in the next spec. What do you think?

> * The included startup script /usr/share/autostart/beagled.desktop starts
>   beagled, you should add "Requires: beagle"

I thought that Requires should never be used. I verified its dependencies and 
it depends only on libbeagle. Maybe this is an exception? What do you think? I 
think I can put :-)

> * You may want to add --only-show-in=KDE in the desktop file install
> command, GNOME users already have frontends to query beagle.

I didn't know that, thanks for letting me know :)

> 
> Minor:
> * The comment "Removing statically linked libraries" is wrong, you are
> removing libtool archive files. Statically linked libs end in ".a"

Fixed! I got confused, thanks!

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.