[Bug 193154] Review Request: asymptote - Descriptive vector graphics language

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: asymptote - Descriptive vector graphics language


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=193154





------- Additional Comments From gemi at bluewin.ch  2006-05-25 18:48 EST -------
Here a few things from first sight:
* Why do you copy things into the docdir instead of just using %doc?
  Also the doc directory is not owned.
  A proposal for what I did instead of the patch:
  add the option docdir=doc-install to configure, then you
  can simply use %doc doc-install/* in the files section:
    %doc LICENSE README TODO BUGS
    %doc doc-install/*
    %doc doc/asymptote.pdf
* The package must own directory %{_datadir}/%{name}
* The package must own directory %{texpkgdir}
* Possibly add a file asy-init.el to /usr/share/emacs/site-lisp/site-start.d:
  (autoload 'asy-mode "asy-mode.el" "Asymptote major mode." t)
  (add-to-list 'auto-mode-alist '("\\.asy$" . asy-mode))
  and something analogous for xemacs.

Output of rpmlint:
W: asymptote symlink-should-be-relative /usr/share/emacs/site-lisp/asy-mode.el
/usr/share/asymptote/asy-mode.el
W: asymptote symlink-should-be-relative /usr/share/vim/vim64/syntax/asy.vim
/usr/share/asymptote/asy.vim
W: asymptote symlink-should-be-relative /usr/share/vim/vim70/syntax/asy.vim
/usr/share/asymptote/asy.vim
W: asymptote symlink-should-be-relative /usr/share/vim/vim63/syntax/asy.vim
/usr/share/asymptote/asy.vim
W: asymptote symlink-should-be-relative
/usr/share/xemacs/site-packages/lisp/asy-mode.el /usr/share/asymptote/asy-mode.el
W: asymptote dangerous-command-in-%trigger ln
W: asymptote dangerous-command-in-%trigger ln
W: asymptote dangerous-command-in-%trigger rm
W: asymptote dangerous-command-in-%trigger rm
W: asymptote percent-in-%trigger
W: asymptote dangerous-command-in-%trigger ln
W: asymptote percent-in-%trigger
W: asymptote dangerous-command-in-%trigger rm
W: asymptote percent-in-%trigger
W: asymptote dangerous-command-in-%trigger rm


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.