[Bug 193157] Review Request: system-config-selinux

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: system-config-selinux


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=193157





------- Additional Comments From paul at city-fan.org  2006-05-26 10:51 EST -------
Would it not be possible for Red Hat-internal projects like this to have their
own mini-homepage so that URL: tags of http://www.redhat.com/ and Source0: tags
that aren't full URLs could be avoided?

Perhaps the spec file template could be updated to use the more modern "make
DESTDIR=${RPM_BUILD_ROOT}" style instead of "%makeinstall"?

/usr/share/system-config-selinux/semanagegui.py
and
/usr/share/system-config-selinux/system-config-selinux.py

have shellbangs:
#!/usr/bin/python2

which lead to bogus dependencies on /usr/bin/python2, which make the package
uninstallable. Since at least the latter needs to be directly executable, it
should have a shellbang pointing to /usr/bin/python

It would be nice if the .pyo files were %ghosted, as is the usual practice these
days.

"manageing" in %description should be "managing"

Regarding Comment #1, which Hardset Requires are you referring to? I can only
see the usermode dep, and that's needed.


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.