[Bug 192540] Review Request: cal3d - A skeletal based 3-D character animation library

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: cal3d - A skeletal based 3-D character animation library


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=192540


wart at kobold.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
         AssignedTo|bugzilla-sink at leemhuis.info |wart at kobold.org
OtherBugsDependingO|163776                      |163778
              nThis|                            |




------- Additional Comments From wart at kobold.org  2006-05-26 14:34 EST -------
MUST
====
* rpmlint output clean
* source matches upstream
  47b3b72c6adcf5351f0884639d606d05  cal3d-full-0.10.0.tar.bz2
* Macro usage consistent
* Package named appropriately
* Spec file legible and in Am. English
* headers, .pc, and unversioned .so's are in -devel
* -devel contains fully-versioned dependency on base package
* LGPL license ok, license file included
* No locales
* ldconfig called in %post/%postun for shared libs
* Not relocatable
* Owns directories that it creates
* No duplicate %files
* Builds in mock on:
  FC4-i386, FC4-x86_64, FC5-i386, FC5-x86_64, devel-i386, devel-x86_64

SHOULD
======
* Ask upstream to include pregenerated configure scripts in their
  published tarballs.  I heard through the grapevine that upstream has moved
their download server off of sourceforge and produced a new source tarball that
doesn't require running 'autoreconf'.  I'd suggest using that tarball, but won't
consider it a blocker.

* My personal preference is to remove the *.la files in %install instead
  of %excluding them so that the %files section is cleaner.

MUSTFIX
=======
* Don't use %{name} in %description or the -devel package summary
* Remove the leading 'A' from the Summary


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.