[Bug 190390] Review Request: AGReader: Console reader for viewing AmigaGuide files

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: AGReader: Console reader for viewing AmigaGuide files


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=190390





------- Additional Comments From j.w.r.degoede at hhs.nl  2006-05-27 05:45 EST -------
Created an attachment (id=130064)
 --> (https://bugzilla.redhat.com/bugzilla/attachment.cgi?id=130064&action=view)
Patch fixing gcc41 compile and all compiler warnings

Ok,

Attached is a patch fixing compiling with gcc4.1 and all compiler warnings.
also I've removed the -s from the link command in the Makefile so that a proper
-debuginfo package can be generated by rpmbuild.

About the name, the name as is is fine, especially if you've already released
rpms with the name like this.

On to a full review:

MUST:
=====
0 rpmlint output is:
W: AGReader incoherent-version-in-changelog 1.1-7.iss 1.1-7
This needs fixing.
* Package and spec file named appropriately
* Packaged according to packaging guidelines
* License (GPL) ok, license file not included because it isn't included by
upstream
* spec file is legible and in Am. English.
* Source matches upstream
* Compiles and builds on devel-x86_64
* BR: ok
* No locales
* No shared libraries
* Not relocatable
* Package owns / or requires all dirs
* No duplicate files & Permissions ok
* %clean & macro usage OK
* Contains code only
* %doc does not affect runtime, and isn't large enough to warrent a sub package

* no -devel package needed, no libs / .la files.
* no gui -> no .desktop file required


MUST fix:
=========
* Drop CC=gcc32 from make command params and instead use the attached patch
* Add CFLAGS="$RPM_OPT_FLAGS" to make command params so that the rpmoptflags
get
  used during compilation.
* Fix incoherent Changelog version.
* Home, End, F1, F2, F3 Keys don't work as advertised in the manual, I've a fix

  and I'll attach a patch for this.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.