[Bug 191540] Review Request: perl-Net-XMPP

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: perl-Net-XMPP


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=191540


tibbs at math.uh.edu changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
OtherBugsDependingO|163778                      |163779
              nThis|                            |




------- Additional Comments From tibbs at math.uh.edu  2006-05-27 22:39 EST -------
This fails to build in mock due to the test suite; some tests are automatically
skipped but t/roster dies:

t/roster.................Cannot resolve compute20.math.uh.edu:  at
/usr/lib/perl5/vendor_perl/5.8.8/XML/Stream.pm line 406.
# Looks like you planned 75 tests but only ran 1.
# Looks like your test died just after 1.
dubious
        Test returned status 255 (wstat 65280, 0xff00)
DIED. FAILED tests 2-75
        Failed 74/75 tests, 1.33% okay
Failed Test Stat Wstat Total Fail  Failed  List of Failed
-------------------------------------------------------------------------------
t/roster.t   255 65280    75  148 197.33%  2-75
8 subtests skipped.
Failed 1/11 test scripts, 90.91% okay. 74/650 subtests failed, 88.62% okay.

BR: perl is redundant, but not a blocker.

I've disabled the tests for the purposes of this review.

Since the only issue is that you need to disable the test suite in order to
build, I'll go ahead and approve and you can fix it when you check in.

Review:
* package meets naming and packaging guidelines.
* specfile is properly named, is cleanly written and uses macros consistently.
* dist tag is present.
* license field matches the actual licenses
* license is open source-compatible.  Text of all licenses included in package.
* source files match upstream:
   6338484aa0d394e68c01666ca34e5241  Net-XMPP-1.0.tar.gz
   6338484aa0d394e68c01666ca34e5241  Net-XMPP-1.0.tar.gz-srpm
* latest version is being packaged.
O BuildRequires are proper (perl is redundant).
O package builds in mock (development, x86_64) once test suite is disabled.
* rpmlint is silent.
* final provides and requires are sane:
   perl(Net::XMPP) = 1.0
   perl(Net::XMPP::Client)
   perl(Net::XMPP::Connection)
   perl(Net::XMPP::Debug)
   perl(Net::XMPP::IQ)
   perl(Net::XMPP::JID)
   perl(Net::XMPP::Message)
   perl(Net::XMPP::Namespaces)
   perl(Net::XMPP::Presence)
   perl(Net::XMPP::PrivacyLists)
   perl(Net::XMPP::Protocol)
   perl(Net::XMPP::Roster)
   perl(Net::XMPP::Stanza)
   perl-Net-XMPP = 1.0-4.fc6
  -
   perl >= 0:5.003
   perl >= 0:5.005
   perl(:MODULE_COMPAT_5.8.8)
   perl(Authen::SASL)
   perl(Carp)
   perl(Digest::SHA1)
   perl(FileHandle)
   perl(MIME::Base64)
   perl(Net::XMPP::Client)
   perl(Net::XMPP::Connection)
   perl(Net::XMPP::Debug)
   perl(Net::XMPP::IQ)
   perl(Net::XMPP::JID)
   perl(Net::XMPP::Message)
   perl(Net::XMPP::Namespaces)
   perl(Net::XMPP::Presence)
   perl(Net::XMPP::PrivacyLists)
   perl(Net::XMPP::Protocol)
   perl(Net::XMPP::Roster)
   perl(Net::XMPP::Stanza)
   perl(POSIX)
   perl(Time::Local)
   perl(XML::Stream) >= 1.22
   perl(base)
   perl(strict)
   perl(vars)
* no shared libraries are present.
* package is not relocatable.
* owns the directories it creates.
* doesn't own any directories it shouldn't.
* no duplicates in %files.
* file permissions are appropriate.
* %clean is present.
O %check is present but must be disabled for mock builds.
* no scriptlets present.
* code, not content.
* documentation is small, so no -docs subpackage is necessary.
* %docs are not necessary for the proper functioning of the package.
* no headers.
* no pkgconfig files.
* no libtool .la droppings.
* not a GUI app.

APPROVED

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.