[Bug 187621] Review Request: blam

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: blam


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=187621


jpmahowald at gmail.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
         AssignedTo|bugzilla-sink at leemhuis.info |jpmahowald at gmail.com
OtherBugsDependingO|                            |163779
              nThis|                            |




------- Additional Comments From jpmahowald at gmail.com  2006-05-28 16:39 EST -------
- rpmlint checks return:
W: blam non-conffile-in-etc /etc/gconf/schemas/blam.schemas

- package meets naming guidelines
- package meets packaging guidelines
- license (GPL) OK, text in %doc, matches source
- spec file legible, in am. english
- source matches upstream
- package compiles on devel (x86_64)
- no missing BR
- no unnecessary BR
- locales handled with %find_lang
- not relocatable
- owns all directories that it creates
- no duplicate files
- permissions ok
- %clean ok
- macro use consistent
- code, not content
- no need for -docs
- nothing in %doc affects runtime
- .desktop file
- works

APPROVED

I'll work on getting the patch to the author.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.