[Bug 192313] Review Request: koan

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: koan


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=192313





------- Additional Comments From jonathan.underwood at gmail.com  2006-05-29 14:13 EST -------
A couple of quick comments:

1) The three macros at the top of the file are totally redundant.
2) Remove Vendor tag.
3) Relaease should contain the dist tag
4) The Prefix tag seems redundant ( I may be missing something there tho).
5) the install section should begin with rm -rf $RPM_BUILD_ROOT

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.