[Bug 187430] Review Request: elektra

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: elektra


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=187430





------- Additional Comments From pertusus at free.fr  2006-05-29 18:37 EST -------
rpmlint output:

E: elektra configure-without-libdir-spec

I don't understand this one.

W: elektra devel-file-in-non-devel-package /lib/libelektra-default.so

Safe to ignore - as long as having dlopened libs in /lib is accepted,
as it is a link to a dlopened lib.

E: elektra script-without-shellbang
/usr/share/doc/elektra-0.6.1/scripts/convert-hwconfKudzu

The shellbang should be 
#!/usr/bin/perl
and if you want to avoid the dependency on perl, you should
chmod -x  

E: elektra-devel no-ldconfig-symlink /usr/lib/libelektratools.so
E: elektra-devel no-ldconfig-symlink /usr/lib/libelektra.so

This should be acted upon (those should be symlinks and not 
files).

E: elektra invalid-soname /lib/libelektra-filesys.so libelektra-filesys.so
E: elektra invalid-soname /lib/libelektra-fstab.so libelektra-fstab.so
E: elektra-backend-berkeleydb invalid-soname /lib/libelektra-berkeleydb.so
libelektra-berkeleydb.so

That's strange. They seems to me to be acceptable sonames for dlopened
libs. Maybe it is an error that happens when dlopened libs are put in 
standard library directories. As said in a comment above, putting 
those dlopened libs in /lib/elektra/ should be much better.

W: elektra-backend-berkeleydb no-documentation

Safe to ignore.

> > other comments:
> > * --prefix=%{_prefix} and --exec-prefix=/ were unneeded in my tests
> 
> This is correct. If removed, software won't be installed in /bin and /lib

I guess you wanted to say incorrect. But it is not incorrect, the
software is installed in /bin and /lib thanks to 
     --bindir=/bin \
     --libdir=/%{_lib} \

Have a look at the resulting variables in config.log.

> The key.3.gz conflict was also removed.

There is still /bin/kdb, kdb.{1,3}, kdb.h which are somehow generic 
but could be acceptable.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.