[Bug 187430] Review Request: elektra

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: elektra


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=187430





------- Additional Comments From avi at unix.sh  2006-05-30 00:00 EST -------
Check update on 
http://prdownloads.sourceforge.net/elektra/elektra-0.6.1-32.src.rpm

The rpmlint output is almost empty now.

> E: elektra script-without-shellbang
> /usr/share/doc/elektra-0.6.1/scripts/convert-hwconfKudzu
> 
> The shellbang should be 
> #!/usr/bin/perl
> and if you want to avoid the dependency on perl, you should
> chmod -x  

Fixed. Thanks.



> E: elektra-devel no-ldconfig-symlink /usr/lib/libelektratools.so
> E: elektra-devel no-ldconfig-symlink /usr/lib/libelektra.so
> 
> This should be acted upon (those should be symlinks and not 
> files).

Fixed.
I did this on spec:
rm $RPM_BUILD_ROOT/%{_lib}/libelektra.so
ln -sf ../../%{_lib}/libelektra.so.2 $RPM_BUILD_ROOT/%{_libdir}/libelektra.so

Any suggestion for a cleaner way without hardcoding the lib version ?



> > > other comments:
> > > * --prefix=%{_prefix} and --exec-prefix=/ were unneeded in my tests
> > 
> > This is correct. If removed, software won't be installed in /bin and /lib
> 
> I guess you wanted to say incorrect. But it is not incorrect, the
> software is installed in /bin and /lib thanks to 
>      --bindir=/bin \
>      --libdir=/%{_lib} \

Fixed. Thanks.

Most warnings are due to some bug in the build system claiming "warning: 
implicit declaration of function 'usleep'". They are sort of fake, and will be 
fixed.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.