[Bug 213511] Review Request: gxine - Gnome frontend for the xine multimedia library

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: gxine - Gnome frontend for the xine multimedia library


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=213511


michel.salim at gmail.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |michel.salim at gmail.com




------- Additional Comments From michel.salim at gmail.com  2006-11-01 21:53 EST -------
Preliminary review:

rpmlint:
- clean on srpm
- one warning on binary: "incoherent-version-in-changelog 0.5.8 0.5.8-1"

To fix this, add the release number to your changelog entries

BuildRequires:
glib2-devel is redundant (pulled in by gtk2-devel)
gettext is missing

You need to use the find_lang macro to find the locale files, not hardcode them
yourself:

http://fedoraproject.org/wiki/Packaging/Guidelines#head-8c605ebf8330f6d505f384e671986fa99a8f72ee



-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.