[Bug 213511] Review Request: gxine - Gnome frontend for the xine multimedia library

bugzilla at redhat.com bugzilla at redhat.com
Fri Nov 3 18:01:07 UTC 2006


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: gxine - Gnome frontend for the xine multimedia library


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=213511





------- Additional Comments From michel.salim at gmail.com  2006-11-03 13:01 EST -------
Created an attachment (id=140298)
 --> (https://bugzilla.redhat.com/bugzilla/attachment.cgi?id=140298&action=view)
Patch to gxine.spec

Several things:
- The find-lang.sh in redhat-rpm-config does not support the --all-name switch,
so I'm using the one in /usr/lib/rpm instead. The proper way of using
%find_lang is commented out, you can uncomment it when redhat-rpm-config is
updated

- the version numbers you use in the changelog were incorrect. Separate version
number and release number with -, not .

You might want to consider BuildReq:ing the other libraries specified in the
INSTALL file? A lot of them are in core and/or extras, so you might want to
turn on support for them. Dual-monitor people will be really annoyed if you
don't link against Xinerama :)


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.




More information about the Fedora-package-review mailing list