[Bug 203520] Review Request: evolution-brutus

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: evolution-brutus
Alias: evolution-brutus

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=203520





------- Additional Comments From colding at omesc.com  2006-11-03 19:22 EST -------
(In reply to comment #48)
> 2nd review of this package:
> 
> A. From http://fedoraproject.org/wiki/Packaging/Guidelines :
> 
> * Use rpmlint
>   rpmlint is not yet silent.
> ---------------------------------------------------------
> W: evolution-brutus devel-file-in-non-devel-package /usr/lib/libBrutusd-1.0.so
> W: evolution-brutus devel-file-in-non-devel-package /usr/lib/libBrutus-1.0.so
> W: evolution-brutus devel-file-in-non-devel-package /usr/lib/libBrutusPROXY-1.0.so
> W: evolution-brutus devel-file-in-non-devel-package /usr/lib/libBrutusSTUBS-1.0.so
> W: evolution-brutus devel-file-in-non-devel-package /usr/lib/libBrutusSKELS-1.0.so
> ---------------------------------------------------------
>   These files should be in -devel package.

Yes, I noticed that rpmlint complained about these files too, but I think it is
a faulty error. These libraries are required by evolution-brutus and its helper
applications. evolution-brutus would not function if they were absent. They
really do not belong in the -devel package so I ignored rpmlint on this one. Am
I in error here?

 
> * BuildRequires:
>   The following BR are redundant.
>   - libglade2-devel <- this is required by gtkhtml3-devel
>                     <- this is required by evolution-devel

OK, fixed.


> * Requires:
>   - For -devel package:
>     Well, .pc files only includes:
> ---------------------------------------------------------
> Requires: libIDL-2.0 >= 0.8.5, ORBit-2.0 >= 2.14.1, libBrutusSTUBS-1.0,
> libBrutusSKELS-1.0
> Requires: libIDL-2.0 >= 0.8.5, ORBit-2.0 >= 2.14.1, libBrutusSTUBS-1.0
> Requires: libIDL-2.0 >= 0.8.5, ORBit-2.0 >= 2.14.1, libBrutusSTUBS-1.0
> Requires: libIDL-2.0 >= 0.8.5, ORBit-2.0 >= 2.14.1 
> Requires: libIDL-2.0 >= 0.8.5, ORBit-2.0 >= 2.14.1, libBrutusSTUBS-1.0
> ---------------------------------------------------------
>     This usually means that -devel package only requies:
>     * main package
>     * pkgconfig
>     * ORBit2-devel (libIDL-devel is required by ORBit2-devel)
> 
>     Would you explain why -devel package requires some extra packages?

I would if I could ;-) 

I think that I confused a require statement with a buildrequire statement. Most
of those additional packages are definitely not needed to use an
evolution-brutus-devel installation. I've update libBrutus-1.0.pc as
applications linking against libBrutus-1.0 would require to link with
libecal-1.2 as well. This should otherwise be fixed now I hope. libecal is
provided by evolution-data-server-devel so I've kept evolution-data-server-devel
in the Require. 

>   - By the way, .pc files includes:
>     Cflags: <skip> -I/lib/glib-2.0/include
>     This causes no problem (so this is not a blocker), however, this makes
>     no sense.

Agreed, no sense at all. Fixed.


> = From http://fedoraproject.org/wiki/Packaging/ReviewGuidelines: None
> 
>
-------------------------------------------------------------------------------------
> NOTE: Before being sponsored:
> 
> This package will be accepted with another few work. But before I accept
> this package, someone (I am a candidate) should sponsor you.
> 
> Once you are sponsored, you have the right to formally review other 
> submitters' review request and approve the packages. 
> For this reason, the person who want to be sponsored (like you) 
> are required to "show that you have an understanding 
> of the process and of the packaging guidelines".
> 
> Usually there are two ways to show this.
> A. submit other review requests with enough quality.
> B. Do a "pre-review" (at the time you are not sponsored, you cannot do
>    a formal review) of other person's review request.
> 
> Please check the details on
> http://fedoraproject.org/wiki/Extras/HowToGetSponsored

Yes, I will attempt to do some pre-reviews. I don't have any other packages at
hand so pre-reviews seems the way to go.

New files here:

SRPM:
http://www.omesc.com/content/downloads/dist/Fedora%20Core%20Development/SRPMS/evolution-brutus-1.1.10-1.src.rpm

SPEC:
http://www.omesc.com/content/downloads/dist/Fedora%20Core%20Development/SPECS/evolution-brutus.spec

Thanks,
  jules


 



-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.