[Bug 213432] Review Request: kaffeine - Xine-based media player

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: kaffeine - Xine-based media player


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=213432





------- Additional Comments From cgoorah at yahoo.com.au  2006-11-04 06:14 EST -------
#001
Isn't it time to merge drop "%{?fedora}" > "2" ?

%if "%{?fedora}" > "2" || "%{?rhel}" > "4"
%define _with_gstreamer --with-gstreamer
%endif

I recommend to merge it with %if "%{?fedora}" > "4" || "%{?rhel}" > "4"

#002
desktop-file-install \
  --vendor="" \

use fedora as vendor :)
desktop-file-install --vendor fedora \

#003
README*
There is one README file to me.

#004
BuildRequires: cdparanoia-devel cdparanoia
cdparanoia-devel already requires cdparanoia

correct these,  I'll approve it as quick as possible

#005:
can you contact upstream to update their download page
http://kaffeine.sourceforge.net/index.php?page=download with respect to fedora.
I just want people to have a good fedora KDE image :)



-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.