[Bug 214055] Review Request: scummvm - Interpreter for several adventure games

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: scummvm - Interpreter for several adventure games
Alias: scummvm

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=214055





------- Additional Comments From j.w.r.degoede at hhs.nl  2006-11-06 09:22 EST -------
(In reply to comment #6)
> Quick comments :
> - You don't need to use "--add-category X-Fedora" any more (it's useless)
I know, but AFAIK the guidelines haven't been updated with regards to this, so
I'm keeping this as is for all my packages for now to keep things consistent.
I'll start fixing this to match the new guidelines when there are new guidelines
and as / when packages need updating fro something more important.

> - For all the icons/hicolor files, I'd use "install -D" to remove all mkdir lines
And right you would be, however I'm used to doing it this way, maybe its time to
change my habbits? But this works and is much easier to read for people who are
not known with the more obscure install cmdline options.

> - The scummvm-icons could maybe be extracted at prep time with ImageMagick

I've tried but the .ico file contains 8, 16 and 32 bit versions of each icon
(the 128x128 is only available in 32 bit) and ImageMagick fails on extracting
the 32 bit ones (the colors are all messed up).


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.