[Bug 203520] Review Request: evolution-brutus

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: evolution-brutus
Alias: evolution-brutus

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=203520





------- Additional Comments From mtasaka at ioa.s.u-tokyo.ac.jp  2006-11-06 11:53 EST -------
Well, as I said before, I cannot precisely check your srpm now.
however:

A. undefined non-weak symbols reappeared.
----------------------------------------------------------
W: evolution-brutus undefined-non-weak-symbol /usr/lib/libBrutus-1.0.so.1.0.0
camel_object_type
W: evolution-brutus undefined-non-weak-symbol /usr/lib/libBrutus-1.0.so.1.0.0
camel_object_cast
W: evolution-brutus undefined-non-weak-symbol /usr/lib/libBrutus-1.0.so.1.0.0
camel_base64_decode_simple
W: evolution-brutus undefined-non-weak-symbol /usr/lib/libBrutus-1.0.so.1.0.0
camel_multipart_get_number
W: evolution-brutus undefined-non-weak-symbol /usr/lib/libBrutus-1.0.so.1.0.0
camel_stream_mem_new
W: evolution-brutus undefined-non-weak-symbol /usr/lib/libBrutus-1.0.so.1.0.0
camel_internet_address_get
W: evolution-brutus undefined-non-weak-symbol /usr/lib/libBrutus-1.0.so.1.0.0
camel_mime_message_get_recipients
W: evolution-brutus undefined-non-weak-symbol /usr/lib/libBrutus-1.0.so.1.0.0
camel_mime_part_get_content_id
W: evolution-brutus undefined-non-weak-symbol /usr/lib/libBrutus-1.0.so.1.0.0
camel_mime_part_get_description
...............................
----------------------------------------------------------
Through brief check, 
----------------------------------------------------------
diff -uNr evolution-brutus-1.1.9/server/Makefile.am
evolution-brutus-1.1.12/server/Makefile.am
--- evolution-brutus-1.1.9/server/Makefile.am   2006-10-19 17:14:31.000000000 +0900
+++ evolution-brutus-1.1.12/server/Makefile.am  2006-11-04 09:05:28.000000000 +0900
@@ -40,7 +40,7 @@
        brutus_conv.c
 
 libBrutus_1_0_la_LIBADD = \
-       $(CALENDAR_LIBS)                                                       
                    \
+       -lecal-1.2 \
       
$(BRUTUS_top_dir)/idl_output/libBrutusSTUBS-$(LIBBRUTUS_CURRENT).$(LIBBRUTUS_REVISION).la
  \
       
$(BRUTUS_top_dir)/servant_impl/libBrutusSKELS-$(LIBBRUTUS_CURRENT).$(LIBBRUTUS_REVISION).la
--------------------------------------------------------------------------------
Perhaps this is somewhat incorrect.

B. 
 %package devel
Summary:          IDL and header files for evolution-brutus
Group:            Development/Libraries
Requires:         %name = %{version}-%{release}
Requires:         ORBit2-devel >= 2.14.1
Requires:         pkgconfig >= 0.20
Requires:         evolution-data-server >= 1.6

Perhaps the last line should be "evolution-data-server-devel >= 1.6"
Then evolution-data-server-devel requires libbonobo-devel, which requires
ORBit2-devel, then 
"Requires:         ORBit2-devel >= 2.14.1"
is not necessary.
 


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.