[Bug 213511] Review Request: gxine - Gnome frontend for the xine multimedia library

bugzilla at redhat.com bugzilla at redhat.com
Tue Nov 7 18:32:34 UTC 2006


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: gxine - Gnome frontend for the xine multimedia library


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=213511


michel.salim at gmail.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #140298|0                           |1
        is obsolete|                            |




------- Additional Comments From michel.salim at gmail.com  2006-11-07 13:32 EST -------
Created an attachment (id=140580)
 --> (https://bugzilla.redhat.com/bugzilla/attachment.cgi?id=140580&action=view)
Updated spec

There are missing BuildReqs still. The INSTALL file in the tarball describes
what libraries you want to link against and why; I've added them (libXext for
DPMS, dbus-glib-devel for controlling the screensaver, and libXaw-devel and
nspr-devel for the Mozilla browser plugin).

Versioning the dependencies is not required if the target distribution has the
required packages. Also, your Requires: declarations are not necessary either.
RPM automatically adds those in (try rpm -qp --requires <binary rpm>).

Building this in mock now to test.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.




More information about the Fedora-package-review mailing list