[Bug 200666] Review Request: theora-exp - Experimental theora decoder

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: theora-exp - Experimental theora decoder


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=200666





------- Additional Comments From j.w.r.degoede at hhs.nl  2006-11-07 16:38 EST -------
(In reply to comment #7)
> Created an attachment (id=139996)
 --> (https://bugzilla.redhat.com/bugzilla/attachment.cgi?id=139996&action=view) [edit]
> suggestions for the spec file
> 
> - Maybe better to use "svn release" instead of "cvs date" ?
> - The "man version" seems to be 0.0.1 (atleast according to result library's
> .so.0.0.1 )
> - The "doc/" subdir can be removed from svn source too (it can significantly
> decrease the size of srpm :) )

All good ideas, thus I've applied your patch, thanks!

> - Maybe enable encoding support too?
No lets not the docs clearly state that this is experimental, so that is an
experimental part of an experimental version, bad idea! Also the docs state that
there are no guarantees files created with the encoder will keep working with
newer theora versions!

> - And how about tools/ subdir?
Those don't look very usefull for generic purposes

> - Maybe include "examples/" dir into %doc for devel subpackage?
This is commonly not done unless upstream really intends for the examples to get
installed, iow "make install" installs them.


A new version with the suggested improvements and updated to a newer snapshot it
available here:
Spec File: http://people.atrpms.net/~hdegoede/theora-exp.spec
SRPM File: http://people.atrpms.net/~hdegoede/theora-exp-0.0.1-0.1.svn12061.src.rpm

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.