[Bug 214055] Review Request: scummvm - Interpreter for several adventure games
bugzilla at redhat.com
bugzilla at redhat.com
Tue Nov 7 22:55:06 UTC 2006
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: Review Request: scummvm - Interpreter for several adventure games
Alias: scummvm
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=214055
chris.stone at gmail.com changed:
What |Removed |Added
----------------------------------------------------------------------------
OtherBugsDependingO|163778 |163779
nThis| |
------- Additional Comments From chris.stone at gmail.com 2006-11-07 17:55 EST -------
==== REVIEW CHECKLIST ====
- rpmlint output
E: scummvm configure-without-libdir-spec
Okay, covered in comment #9. Should mention why you are not using libdir in
comments though.
- package named according to guidelines
- spec filename matches %{name}
- package meets packaging guidelines
- package licensed with open source compatible license
- license matches actual license
- license file included in %doc
- spec file in American english
- spec file legible
- source match upstream
30a82ad466bae223875e66ee14b94904 scummvm-0.9.1.tar.bz2
- package successfully compiles and builds on FC5 x86_64
- all build dependencies listed in BR
- package does not use locales
- package does not contain shared libraries
- package is not relocatable
- package owns all directories it creates
- no duplicates in %files
- file permissions set properly
- package contains proper %clean
- macro usage consistent
- package contains code
- package does not contain large documentation
- files in %doc do not affect runtime
- no header or libraries files or devel subpackage required
- no pkgconfig files
- no .la files
- package contains proper .desktop scriptlets
- package does not own files or directories owned by other packages
APPROVED
==== SHOULD ====
- please add to configure comments something about no --libdir since rpmlint
gives an Error on this.
--
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.
More information about the Fedora-package-review
mailing list