[Bug 204700] Review Request: njb-sharp - C# bindings to libnjb
bugzilla at redhat.com
bugzilla at redhat.com
Tue Nov 7 23:24:25 UTC 2006
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: Review Request: njb-sharp - C# bindings to libnjb
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=204700
paul at all-the-johnsons.co.uk changed:
What |Removed |Added
----------------------------------------------------------------------------
OtherBugsDependingO|163778 |163779
nThis| |
------- Additional Comments From paul at all-the-johnsons.co.uk 2006-11-07 18:24 EST -------
rpmlint is clean, builds fine in mock (x86)
Review
Spec file clear and in US English
Consistent use of macros
FC-5 macro requires (permitted)
Upstream tarball md5 is the same as the packaged version
License good
pkgconfig included for devel package
Uses DESTDIR for the install
post and postun make sense
clean present
docs included in main package
owns correct files
Links with test code
Okay, I'm happy with this. Please close the bug and set as NEXT RELEASE
APPROVED
Please remember that when FC-5 comes up to date with FC-6's mono, the macro will
need to be replaced.
--
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.
More information about the Fedora-package-review
mailing list