[Bug 214057] Review Request: beneath-a-steel-sky - Beneath a Steel Sky - Adventure Game

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: beneath-a-steel-sky - Beneath a Steel Sky - Adventure Game
Alias: scummvm-bass

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=214057





------- Additional Comments From chris.stone at gmail.com  2006-11-08 18:18 EST -------
==== REVIEW CHECKLIST ====
- rpmlint output
W: beneath-a-steel-sky no-%build-section

rpmlint says you should add this section even if empty.  See rpmlint -I
no-%build-section.  I tend to agree.  While it might not make a difference now
(no debuginfo package is built but we dont care) there may be something in the
future which checks for this and there is no harm in adding it, so unless you
have a specific technical reason to comment it, id say just uncomment it.
- package named according to package naming guidelines (although a provides bass
might make it easier to install)
- spec filename matches package %{name}
- package meets packaging guidelines
- package is licensed as "Distributable"
FOR FURTHER DISCUSSION ON DISTRIBUTION RIGHTS SEE:
https://www.redhat.com/archives/fedora-extras-list/2006-November/msg00030.html
- License file included in %doc
- spec written in American english
- spec file is legible
- sources match upstream (however source0 location needs fixing)
cb968b4cfdde8491069915bf15d275b3  BASS-Floppy.zip
- package successfully compiles and builds on FC5 X86_64
- all dependencies listed in BR
- no locales
- no shared libraries
- package is not relocatable
- package owns all directories it creates
- no duplicates in %files
- file permissions set properly
- package has proper %clean section
- macro usage is consistent
- package contains permissible content
- no large documentation
- no header files or static libraries
- no pkgconfig files
- no devel subpackage required
- no .la files
- package contains proper .desktop file
- package does not own files or directories owned by other packages

==== MUST ====
- Change location of Source0, this file is *NOT* located on sourceforge

==== SHOULD ====
- Add Obsolete/Provides for "bass"
- Uncomment %build
- Add in a comment above the License tag the URL pointing to the discussion on
the distribution:
https://www.redhat.com/archives/fedora-extras-list/2006-November/msg00010.html


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.