[Bug 213832] Review Request: arpwatch - Network monitoring tools for tracking IP addresses on a network

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: arpwatch - Network monitoring tools for tracking IP addresses on a network


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=213832





------- Additional Comments From pertusus at free.fr  2006-11-09 04:53 EST -------
(In reply to comment #6)
> > * The service related scriptlets don't follow the guidelines
> What do you mean?

The scriptlet are not the same than in 
http://fedoraproject.org/wiki/Packaging/ScriptletSnippets#head-97754e2c646616c5f6222f0cfc6923c60765133e
It may not be problematic, those scriptlets could even be better, but
maybe this could be argued.

> > * the adduser followed by a chsh is a bit odd.
> This was probably some preventive action for the case when the user was already
> there. I'd leave it on packager to decide if chsh should be removed or not.

It seems a bit bad to me. I don't think it is a good idea to 
modify the user after the first install. The sysadm may have changed
something on purpose.


> > * if there is a libpcap library nearby (see line 209 to 221
>   in configure.ac) it is used, for example in the BUILD directory. 
>   Maybe this part of the configure/configure.ac could be patched out.
>   It shouldn't be annoying in mock, however.
> I've noticed that too, I don't think it must be fixed but it would be good idea.

This is definitely not a blocker, but an improvement.

> I agree that sendmail probably should be required. smtpdaemon not as it is
> definitely optional thing and arpwatch is usable without it.

smtpdaemon is more or less similar with /usr/sbin/sendmail, in fact
the semantics of this virtual provide is not clear to me. 
/usr/sbin/sendmail is certainly better anyway.

> I don't think that the package should require snmpwalk. This is unnecessary
> bloat in case someone wants to use just arpwatch.

In that case arpfetch shouldn't be installed but in %doc. Otherwise there
is a non-functional script installed. Another option would be to 
document prominently in fedora specific place (%description or README.fedora
for example) that snmpwalk is needed for proper functionning.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.