[Bug 213832] Review Request: arpwatch - Network monitoring tools for tracking IP addresses on a network

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: arpwatch - Network monitoring tools for tracking IP addresses on a network


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=213832





------- Additional Comments From pertusus at free.fr  2006-11-09 13:23 EST -------
In general it is not needed, but I think it could be helpfull in the
case of the one liners of that package to have both versions
of the script to be able to do a gendiff to see what the one-liners
did. It would amount to changing the perl line to look like:

perl -pi.quotes -e "s/\'/\'\\\'\'/g" *.awk

and doing a cp after the sed one liner, something along:

....
                        > $RPM_BUILD_ROOT%{_sbindir}/$i.embedawk
                cp $RPM_BUILD_ROOT%{_sbindir}/$i.embedawk .
                mv $RPM_BUILD_ROOT%{_sbindir}/$i{.embedawk,}
....

After seing the result of the perl one-liner result, I really think 
it should be a patch... For the awk embedding it is certainly better
with the one-liner, but with a way to be able to easily see what was 
changed.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.