[Bug 200666] Review Request: theora-exp - Experimental theora decoder

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: theora-exp - Experimental theora decoder


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=200666


j.w.r.degoede at hhs.nl changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #139996|0                           |1
        is obsolete|                            |




------- Additional Comments From j.w.r.degoede at hhs.nl  2006-11-09 14:33 EST -------
Created an attachment (id=140813)
 --> (https://bugzilla.redhat.com/bugzilla/attachment.cgi?id=140813&action=view)
Updated specfile

(In reply to comment #9)
> * the "-devel" package owns "/usr/include/theora" directory, which is
questionable.
> It seems that libtheora-devel should own this, but currently this dir is not
> owned at all. Anyway, IMO, an Extras package should not own anything already
> present in the Core...
> 

Since theora-exp-devel and theora-exp themselves can be installed without
having
libtheora(-devel) installed, I believe that theora-exp-devel is correct in
owning this dir, otherwise it would be unowned when libtheora(-devel) isn't
installed. The fact that libtheora-devel doesn't own it is a bug. Will you file
this, or shall I?

> * "-devel" package must "Requires: pkgconfig" as it has .pc file
> 

You're correct there.

> * Suggestion: add some words to %description that "theora" is related to
"video
> codec" etc. It could help newbies a little... :)

Good idea! I've attached a new specfile, as for some reason I cannot access
people.atrpms.net ATM.


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.