[Bug 214150] Review Request: flight-of-the-amazon-queen-cd - Flight of the Amazon Queen - Adventure Game - CD version

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: flight-of-the-amazon-queen-cd - Flight of the Amazon Queen - Adventure Game - CD version
Alias: scumm-amazon-CD

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=214150





------- Additional Comments From chris.stone at gmail.com  2006-11-09 18:50 EST -------
==== REVIEW CHECKLIST ====
- rpmlint output
W: flight-of-the-amazon-queen-cd no-%build-section

okay, but no harm in enabling %build either
- spec file named according to package naming guidelines
- spec filename matches %{name}
- package meets packaging guidelines
- licensed as distributable, see
https://www.redhat.com/archives/fedora-extras-list/2006-November/msg00030.html
- License file included in %doc
- spec written in American english
- spec file is legible
X sources match upstream
SOURCES ARE TAKING A LONG TIME TO DOWNLOAD
- package successfully compiles and builds on FC5 X86_64
- all dependencies listed in BR
- no locales
- no shared libraries
- package is not relocatable
- package owns all directories it creates
- no duplicates in %files
- file permissions set properly
- package has proper %clean section
- macro usage is consistent
- package contains permissible content
- no large documentation
- no header files or static libraries
- no pkgconfig files
- no devel subpackage required
- no .la files
- package contains proper .desktop file
- package does not own files or directories owned by other packages

APPROVED (PENDING MD5SUM CHECK ON SOURCES WHEN DOWNLOAD COMPLETE)

==== MUST ====
- wait for me to finsih downloading source from upstream, ftp is *really* slow.
Will commit what I have of the review now, and do an md5sum check when the
download is complete.  Once that is done I will set this as blocking FE-ACCEPT

==== SHOULD ====
- uncomment %build to make rpmlint happy
- add Provides: fotaq-cd for easier commandline installs
- add comment above license pointing to distribution discussions on f-e-l
- remove README.SUSE from %doc I dont see anything useful there for Fedora
installs.  If you want to keep the part about how it was generated this can be
put in a README.FEDORA file.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.