[Bug 214457] Review Request: php-pear-Cache - Framework for caching of arbitrary data

bugzilla at redhat.com bugzilla at redhat.com
Fri Nov 10 04:31:28 UTC 2006


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request:  php-pear-Cache - Framework for caching of arbitrary data
Alias: php-pear-Cache

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=214457


chris.stone at gmail.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
OtherBugsDependingO|163778                      |163779
              nThis|                            |




------- Additional Comments From chris.stone at gmail.com  2006-11-09 23:31 EST -------
==== REVIEW CHECKLIST ====
- rpmlint output clean
- package named according to package naming guidelines
- package licensed with open source compatible license
- license matches actual license
- licnese included in %doc
- spec file written in American english
- spec file legible
- sources match upstream
d7ababc47030b1d69aba655156a41ea3  ../SOURCES/Cache-1.5.5RC4.tgz
- package successfully compiles and builds on FC5 x86_64
- all build dependencies listed in BR
- no locales
- no shared libraries
- not relocatable
- package owns all directories it creates
- no duplicates in %files
- file permissions set properly
- contains proper %clean section
- macro usage is consistent
- contains code
- no large documentation
- files in %doc do not affect runtime
- no header files or static libraries
- no pkgconfig files
- no devel subpackage required
- no .la files
- not a GUI app needing a .desktop file
- packages does not own files or directories owned by other packages

APPROVED

==== SHOULD ====
- Change fullversion to just "beta" and define it to "RC4", then set:

Release: 0.1.%{beta}%{?dist}
Source0 ...%{pear_name}-%{version}{%beta}.tgz

etc..


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.




More information about the Fedora-package-review mailing list