[Bug 214818] Review Request: audacious+audacious-plugins - A GTK2 based media player similar to xmms

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: audacious+audacious-plugins - A GTK2 based media player similar to xmms


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=214818





------- Additional Comments From panemade at gmail.com  2006-11-11 12:09 EST -------
This package needs a lot to do still to go in FE.

rpmlint -iv audacious-1.2.1-0.5.src.rpm gave

W: audacious macro-in-%changelog 20
Macros are expanded in %changelog too, which can in unfortunate cases lead
to the package not building at all, or other subtle unexpected conditions that
affect the build.  Even when that doesn't happen, the expansion results in
possibly "rewriting history" on subsequent package revisions and generally
odd entries eg. in source rpms, which is rarely wanted.  Avoid use of macros
in %changelog altogether, or use two '%'s to escape them, like '%%foo'.

W: audacious macro-in-%changelog 20
Macros are expanded in %changelog too, which can in unfortunate cases lead
to the package not building at all, or other subtle unexpected conditions that
affect the build.  Even when that doesn't happen, the expansion results in
possibly "rewriting history" on subsequent package revisions and generally
odd entries eg. in source rpms, which is rarely wanted.  Avoid use of macros
in %changelog altogether, or use two '%'s to escape them, like '%%foo'.

W: audacious patch-not-applied Patch2: audacious-1.1.0-no-rpath.patch
A patch is included in your package but was not applied. Refer to the patches
documentation to see what's wrong.

W: audacious patch-not-applied Patch5: audacious-1.1.0-amidi-backend.patch
A patch is included in your package but was not applied. Refer to the patches
documentation to see what's wrong.

W: audacious patch-not-applied Patch8: audacious-1.1.1-playlist-twenty.patch
A patch is included in your package but was not applied. Refer to the patches
documentation to see what's wrong.


rpmlint on audacious-libs-1.2.1-0.5.i386.rpm
W: audacious-libs one-line-command-in-%post /sbin/ldconfig
You should use %post -p <command> instead of using:

%post
<command>

It will avoid the fork of a shell interpreter to execute your command as
well as allows rpm to automatically mark the dependency on your command.

W: audacious-libs one-line-command-in-%postun /sbin/ldconfig
You should use %postun -p <command> instead of using:

%postun
<command>

It will avoid the fork of a shell interpreter to execute your command as
well as allows rpm to automatically mark the dependency on your command.


rpmlint on audacious-1.2.1-0.5.i386.rpm
I: audacious checking
W: audacious incoherent-version-in-changelog 1.2.1-0.5.fc7 1.2.1-0.5
The last entry in %changelog contains a version identifier that is not
coherent with the epoch:version-release tuple of the package.

I HOPE ALL rpmlint warnings and errors are SELF-EXPLANATORY here.
Resubmit package solving above errors and warnings.


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.