[Bug 215193] Review Request: VLGothic - Truetype Japanese gothic fonts

bugzilla at redhat.com bugzilla at redhat.com
Sun Nov 12 13:16:34 UTC 2006


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: VLGothic - Truetype Japanese gothic fonts


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=215193





------- Additional Comments From mtasaka at ioa.s.u-tokyo.ac.jp  2006-11-12 08:16 EST -------
Okay, first review of this package.

A. From http://fedoraproject.org/wiki/Packaging/Guidelines :
* Use rpmlint
  - rpmlint is not silent.
------------------------------------
W: VLGothic non-conffile-in-etc /etc/fonts/conf.d/30-VLGothic.conf
------------------------------------
    Use %config(noreplace) unless you have a reason we should not
    use this.

* Summary and desctiption
  - The groups of this package should be 'User Interface/X'.
  - I think that the URL of this package should be:
    'http://dicey.org/vlgothic/'
  - Specify the URL or the location of the source.

* Timestamps
  - Please use 'install -p' to keep timestamps.

* Requires/File and Directory Ownership
  - This package does not own the following directory:

  A. /etc/fonts/ /etc/fonts/conf.d/
     Please add the requirement for this directory like:
     Requires: /etc/fonts/
     or require fontconfig.

  B. /usr/share/fonts/japanese/ /usr/share/fonts/japanese/TrueType
     When this package require fonts-japanese, please write so.
     Otherwise this package should own these directories.

B. From http://fedoraproject.org/wiki/Packaging/ReviewGuidelines :
   = Nothing.


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.




More information about the Fedora-package-review mailing list