[Bug 215193] Review Request: VLGothic-fonts - Truetype Japanese gothic fonts

bugzilla at redhat.com bugzilla at redhat.com
Sun Nov 12 15:49:25 UTC 2006


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: VLGothic-fonts - Truetype Japanese gothic fonts


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=215193





------- Additional Comments From mtasaka at ioa.s.u-tokyo.ac.jp  2006-11-12 10:49 EST -------
Well,

* /usr/share/fonts/japanese is owned only by fonts-japanese so
  this package should also own this directory.
* Do you have some reason not to use noreplace option of config
  file, i.e. not to use 
--------------------------------------------
%config(noreplace) %{_sysconfdir}/fonts/conf.d/30-VLGothic.conf ?
---------------------------------------------
  rpmlint still complain about:
--------------------------------------------
W: VLGothic-fonts conffile-without-noreplace-flag /etc/fonts/conf.d/30-VLGothic.conf
--------------------------------------------
* For src.rpm:
------------------------------------
W: VLGothic-fonts unversioned-explicit-obsoletes VLGothic
W: VLGothic-fonts unversioned-explicit-provides VLGothic
------------------------------------
Usually, obsoletes/provides are done like following:
--------------------------------------
Obsoletes: VLGothic <= %{version}-%{release}
Provides:  VLGothic = %{version}-%{release}
----------------------------------------

* Cosmetic issue:
%dir /usr/share/fonts/japanese/TrueType
This should be %dir %{_datadir}/fonts/japanese/TrueType as
you use %{_datadir} below.


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.




More information about the Fedora-package-review mailing list