[Bug 212715] Review Request: openvrml - VRML/X3D runtime library

bugzilla at redhat.com bugzilla at redhat.com
Mon Nov 13 20:45:49 UTC 2006


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: openvrml - VRML/X3D runtime library


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=212715


rpm at greysector.net changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |rpm at greysector.net




------- Additional Comments From rpm at greysector.net  2006-11-13 15:45 EST -------
I'm interested in having this in Extras, too. A few comments:
1. redundant BuildRequires: pkgconfig (required by freetype-devel and
libpng-devel), libpng-devel (required by cairo-devel, which is required by
gtk2-devel), fontconfig-devel (required by cairo-devel), freetype-devel
(required by fontconfig-devel)
2. use BuildRequires: gecko-devel instead of firefox-devel and libGLU-devel
instead of mesa-libGLU-devel
3. reduntant Requires: mesa-libGLU for -gl subpackage
4. use %setup -q instead of %setup
5. use %configure --disable-dependency-tracking to speed up build process
6. use %{__make} instead of make in %install for consistency
7. avoid unnecessary docs duplication in every subpackage
8. rename mozilla-plugin to plugin


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.




More information about the Fedora-package-review mailing list