[Bug 211319] Review Request: andutteye-client - Andutteye Software Suite Monitoring agent

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: andutteye-client - Andutteye Software Suite Monitoring agent


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=211319





------- Additional Comments From faucamp at csir.co.za  2006-11-14 05:00 EST -------
A quick review of the spec file (I have not installed this application yet):

- The spec file has strange file permissions (750); should be 644
- spec file naming incorrect; should only be "anduttey-client.spec"

SPEC FILE INNARDS:
- spec file format is a bit messy: use "rpmdev-newspec" available from
rpmdevtools in Extras to create a template
- Packager tag should not be present
- "AutoReqProv: no" is present; why? Under normal circumstances this should
never be used.
- License: GPL v2  - should just be GPL (the "v2" not necessary)
- Invalid Group: System Environment/Applications  --- should be Applications/System
- Release tag is invalid: no %{?dist} tag present
- Vendor tag should not be present (set by Fedora buildsys)

- Inconsistent use of RPM_BUILD_ROOT tags, see:
http://fedoraproject.org/wiki/Packaging/Guidelines#head-f3d77b27a5d29dfc1f5600ef3fc836f2e317badf

- %pre and %post scripts are too long, and incorrect (chkconfig and user parts;
I haven't checked the anduttey-specifc stuff): see
http://fedoraproject.org/wiki/Packaging/Guidelines#head-220f87f993c84311859884f2a033a8706a2c7d7c

------- For instance:
<snip>
# Registering services
if [ -f "/sbin/chkconfig" ]
   then
   /sbin/chkconfig --level 3 andutteyed on
   /sbin/chkconfig --level 5 andutteyed on
fi
</snip>

This should be placed in the andutteyed init.d script as defaults for chkconfig,
and should not be managed by your spec file.
Your specfile can then simply register the service with something like:
/sbin/chkconfig --add andutteyed


- %install section: no build root cleanup
--- %install section: install procedure seems to simply dump everything in the
buildroot. Also: Refrain from using /opt; rather use standard directories. Place
executable binaries in /usr/bin (using macros such as %{buildroot}%{_bindir}, etc

--- %pre and %post scripts create new user account and starts/stops service, but
there is no %preun and %postun to "remove" these effects on the system, so the
package is never cleanly uninstalled

--- %files: section is messy; you can use %defattr much more effectively and
remove most of the %attr statements

--- %files: your are using hard-coded paths (e.g. /usr/share/man/man1/*); use
macros instead

--- Changelog inconsistent with release tag

This spec file needs a lot of work. I am also unsure of the requirements of this
package -- does it require the anduttey-server package (which is on the upstream
website)? If this package isn't useful without the -server package, it might be
a good idea to first add the -server to Fedora Extras. 

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.