[Bug 212898] Review Request: php-pear-Structures-DataGrid-Renderer-Pager - Renderer driver using PEAR::Pager

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: php-pear-Structures-DataGrid-Renderer-Pager - Renderer driver using PEAR::Pager
Alias: DG-Renderer-Pager

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=212898


tibbs at math.uh.edu changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
OtherBugsDependingO|163778                      |163779
              nThis|                            |




------- Additional Comments From tibbs at math.uh.edu  2006-11-15 13:17 EST -------
Wow, that's a long filename.  And another no-documentation package, as well. 
What's with the PHP folks?

W: php-pear-Structures-DataGrid-Renderer-Pager no-documentation
W: php-pear-Structures-DataGrid-Renderer-Pager filename-too-long-for-joliet
php-pear-Structures-DataGrid-Renderer-Pager-0.1.0-1.fc7.noarch.rpm

I am not sure what the implications of the massive filename are.  There's
nothing in the guidelines about limiting the length of filenames so I don't
think it's a blocker, but I think the issue needs to be discussed.

Also, php-pear-Structures-DataGrid doesn't seem to be at my mirror yet even
though it was pushed 18 hours ago.  I put it in a local repository.

* source files match upstream:
  6604bb72ff0b78c8651cd17eef0d5fe4  Structures_DataGrid_Renderer_Pager-0.1.0.tgz
* package meets naming and packaging guidelines.
* specfile is properly named, is cleanly written and uses macros consistently.
* dist tag is present.
* build root is correct.
* license field matches the actual license.
* license is open source-compatible.  License text not included upstream.
* latest version is being packaged.
* BuildRequires are proper.
* %clean is present.
* package builds in mock (development, x86_64).
* package installs properly
O rpmlint output is OK
* final provides and requires are sane:
   php-pear(Structures_DataGrid_Renderer_Pager) = 0.1.0
   php-pear-Structures-DataGrid-Renderer-Pager = 0.1.0-1.fc7
  =
   /bin/sh
   /usr/bin/pear
   php-pear(PEAR)
   php-pear(Pager)
   php-pear(Structures_DataGrid)
* %check is not present; no test suite upstream.
* owns the directories it creates.
* doesn't own any directories it shouldn't.
* no duplicates in %files.
* file permissions are appropriate.
* scriptlets are OK (pear module installation).
* code, not content.
* no documentation, so no -docs subpackage is necessary.

APPROVED

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.