[Bug 215569] Review Request: beryl-vidcap - Beryl OpenGL window and compositing manager video capture utility

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: beryl-vidcap - Beryl OpenGL window and compositing manager video capture utility


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=215569





------- Additional Comments From mtasaka at ioa.s.u-tokyo.ac.jp  2006-11-17 11:56 EST -------
Well, during review on beryl-vipcap, several issues are
found.

* %{_libdir}/beryl/libcapture.so contains undefined
  non-weak symbols.
----------------------------------------------------
[tasaka1 at localhost ~]$ ldd -r /usr/lib/beryl/libcapture.so > /dev/null
undefined symbol: glEnd (/usr/lib/beryl/libcapture.so)
undefined symbol: glEnable      (/usr/lib/beryl/libcapture.so)
undefined symbol: glColor4us    (/usr/lib/beryl/libcapture.so)
undefined symbol: glEnableClientState   (/usr/lib/beryl/libcapture.so)
undefined symbol: glDisable     (/usr/lib/beryl/libcapture.so)
undefined symbol: glRecti       (/usr/lib/beryl/libcapture.so)
undefined symbol: addScreenAction       (/usr/lib/beryl/libcapture.so)
undefined symbol: compSetFloatOption    (/usr/lib/beryl/libcapture.so)
undefined symbol: getIntOptionNamed     (/usr/lib/beryl/libcapture.so)
(and others)
----------------------------------------------------
  Please check the linkage against this package.

* Related to above, -devel package are missing necessary
  Requires.
  %{_includedir}/seom/seom.h reads:
----------------------------------------------------
#include <GL/gl.h>
#include <GL/glext.h>
#include <GL/glx.h>

#include <X11/Xlib.h>
#include <X11/Xatom.h>
#include <X11/keysym.h>
----------------------------------------------------
  This means -devel package requires at least the following packages
---------------------------------------------------
libGL-devel (this is provided by mesa-libGL-devel)
libX11-devel
xorg-x11-proto-devel (this is required by mesa-libGL-devel so
                      redundant for writing to Requires)
---------------------------------------------------
  and also this implies that the missing linkage on
  %{_libdir}/beryl/libcapture.so _may_ be for
  libGL.so and libX11.so (I have not checked).

* Fedora specific compilation flags are not passed.
----------------------------------------------------
+ umask 022
+ cd /builddir/build/BUILD
+ cd beryl-vidcap-0.1.2
+ LANG=C
+ export LANG
+ unset DISPLAY
+ rm -rf /var/tmp/beryl-vidcap-0.1.2-6.fc7-root-mockbuild
+ pushd seom
~/build/BUILD/beryl-vidcap-0.1.2/seom ~/build/BUILD/beryl-vidcap-0.1.2
+ make DESTDIR=/var/tmp/beryl-vidcap-0.1.2-6.fc7-root-mockbuild install
cc -W -Wall -std=c99 -Iinclude -ldl -lpthread -L.libs -lseom  -o seom-filter
src/filter/main.c
cc -W -Wall -std=c99 -Iinclude -ldl -lpthread -L.libs -lseom -lX11 -lXv -o
seom-player src/player/main.c
cc -W -Wall -std=c99 -Iinclude -ldl -lpthread -L.libs -lseom  -o seom-server
src/server/main.c
------------------------------------------------------
 (This uses original 0.1.2-6 spec file). Please fix this.

* License:
  I cannot find any GPL license document file in the source
  files. Only I can read is in capture.c, however, it is not
  GPL (looks like "free" license, however, what is this?)

  Well, other files than capture.c don't contain any license
  terms and no license document is provided, so, the license
  of this package is really questionable.......

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.