[Bug 216363] Review Request: labyrinth - Simple but powerful mind-mapping software for GNOME

bugzilla at redhat.com bugzilla at redhat.com
Mon Nov 20 15:42:40 UTC 2006


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: labyrinth - Simple but powerful mind-mapping software for GNOME


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=216363





------- Additional Comments From peter at thecodergeek.com  2006-11-20 10:42 EST -------
Parag: The messages in the build.log are there because the Makefile in data/
contains the following block:

> if test -z "$(DESTDIR)"; then \
>        echo "Updating Gtk icon cache."; \
>        $(gtk_update_icon_cache); \
> else \
>        echo "*** Icon cache not updated.  After install, run this:"; \
>        echo "***   $(gtk_update_icon_cache)"; \
> fi

What this does is test that DESTDIR is empty (the default installation directory
would then be used) and run gtk-update-icon-cache only if so. However, we need
the files to be installed into the build root to be grabbed by rpmbuild rather
than installed to the system directory structure, thus are required to use
DESTDIR=%{buildroot} in the make call.

If you'd like, I could patch this out of the Makefile and not show it; but I
believe it is entirely harmless and feel that such a patch would serve no
significant benefit.

Thanks for your time and review!

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.




More information about the Fedora-package-review mailing list